From 2a080d374b612e89f109079b2e312cd24df7c15f Mon Sep 17 00:00:00 2001 From: zhouyifan279 Date: Tue, 31 Aug 2021 20:36:37 +0800 Subject: [PATCH] [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter ### _Why are the changes needed?_ Executing test case "ServiceDiscoverySuite set up zookeeper auth" on a Linux host named "KYUUBI" fails. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1006 from zhouyifan279/KYUUBI#1005. Closes #1005 045c6b34 [zhouyifan279] [KYUUBI #1005] ServiceDiscoverySuite fails if hostname contains uppercase letter Authored-by: zhouyifan279 Signed-off-by: Cheng Pan (cherry picked from commit 866a63d7a7adb6baeb68c02df39a463887550d1e) Signed-off-by: Cheng Pan --- .../org/apache/kyuubi/ha/client/ServiceDiscoverySuite.scala | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kyuubi-ha/src/test/scala/org/apache/kyuubi/ha/client/ServiceDiscoverySuite.scala b/kyuubi-ha/src/test/scala/org/apache/kyuubi/ha/client/ServiceDiscoverySuite.scala index 8e870efe7..2217e80a5 100644 --- a/kyuubi-ha/src/test/scala/org/apache/kyuubi/ha/client/ServiceDiscoverySuite.scala +++ b/kyuubi-ha/src/test/scala/org/apache/kyuubi/ha/client/ServiceDiscoverySuite.scala @@ -23,6 +23,7 @@ import javax.security.auth.login.Configuration import scala.collection.JavaConverters._ +import org.apache.hadoop.util.StringUtils import org.apache.zookeeper.ZooDefs import org.scalatest.time.SpanSugar._ @@ -125,8 +126,8 @@ class ServiceDiscoverySuite extends KerberizedTestHelper { assert(entries.head.getLoginModuleName === "com.sun.security.auth.module.Krb5LoginModule") val options = entries.head.getOptions.asScala.toMap - assert(options("principal") === - s"kentyao/${InetAddress.getLocalHost.getCanonicalHostName}@apache.org") + val hostname = StringUtils.toLowerCase(InetAddress.getLocalHost.getCanonicalHostName) + assert(options("principal") === s"kentyao/$hostname@apache.org") assert(options("useKeyTab").toString.toBoolean) conf.set(KyuubiConf.SERVER_KEYTAB, keytab.getName)