diff --git a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/log/OperationLog.scala b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/log/OperationLog.scala index 3f37cdf09..67f3d11a6 100644 --- a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/log/OperationLog.scala +++ b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/log/OperationLog.scala @@ -89,8 +89,8 @@ object OperationLog extends Logging { class OperationLog(path: Path) extends Logging { - private lazy val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8) - private lazy val reader = Files.newBufferedReader(path, StandardCharsets.UTF_8) + private val writer = Files.newBufferedWriter(path, StandardCharsets.UTF_8) + private val reader = Files.newBufferedReader(path, StandardCharsets.UTF_8) /** * write log to the operation log file diff --git a/externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/operation/log/OperationLogSuite.scala b/externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/operation/log/OperationLogSuite.scala index 82d76d5fb..080d11fa7 100644 --- a/externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/operation/log/OperationLogSuite.scala +++ b/externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/operation/log/OperationLogSuite.scala @@ -100,4 +100,19 @@ class OperationLogSuite extends KyuubiFunSuite { assert(list2.isEmpty) operationLog.close() } + + test("exception when creating log files") { + val sHandle = SessionHandle(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10) + val logRoot = Paths.get(OperationLog.LOG_ROOT, sHandle.identifier.toString).toFile + logRoot.deleteOnExit() + Files.createFile(Paths.get(OperationLog.LOG_ROOT, sHandle.identifier.toString)) + assert(logRoot.exists()) + OperationLog.createOperationLogRootDirectory(sHandle) + assert(logRoot.isFile) + val oHandle = OperationHandle( + OperationType.EXECUTE_STATEMENT, TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10) + val log = OperationLog.createOperationLog(sHandle, oHandle) + assert(log === null) + + } }