celeborn/sbin
Wang, Fei 1b3bd6eb38 [CELEBORN-1802] Fail the celeborn master/worker start if CELEBORN_CONF_DIR is not directory
### What changes were proposed in this pull request?
Fail the celeborn master/worker start if `CELEBORN_CONF_DIR` is not directory. Otherwise, the  process would run into unexpected status.

### Why are the changes needed?
In the  `celeborn-daemon.sh` , if we specify the `--config <conf-dir>` option. It would fail the master/worker start if the `conf-dir` is not a directory,  likes the systemctl `ConditionPathExists=$CELEBORN_CONF_DIR` requirement check.

fde6365f68/sbin/celeborn-daemon.sh (L35)

fde6365f68/sbin/celeborn-daemon.sh (L53-L62)

But before this PR, for the start master/worker scripts, it did not check if the `CELEBORN_CONF_DIR` is dirctory because the scripts did not leverage `--config <conf-dir>` option.

In this PR, we check the final `CELEBORN_CONF_DIR` before start celeborn, so that all the scripts would check if the `CELEBORN_CONF_DIR` is a directory before start.
### Does this PR introduce _any_ user-facing change?
Yes, it would fail the start if  `CELEBORN_CONF_DIR` is not a directory.

### How was this patch tested?

<img width="840" alt="image" src="https://github.com/user-attachments/assets/e670d21b-cb01-4fa6-8a2f-c94dc06cce4a" />

Closes #3030 from turboFei/check_config_dir.

Authored-by: Wang, Fei <fwang12@ebay.com>
Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
2024-12-26 20:22:34 +08:00
..
celeborn-cli [CELEBORN-1572] Celeborn CLI initial REST API support 2024-09-05 11:15:16 -05:00
celeborn-daemon.sh [CELEBORN-1802] Fail the celeborn master/worker start if CELEBORN_CONF_DIR is not directory 2024-12-26 20:22:34 +08:00
load-celeborn-env.sh [CELEBORN-1682] Add java tools.jar into classpath for JVM quake 2024-11-04 11:05:10 +08:00
restart-worker.sh [CELEBORN-1777] Add java.security.jgss/sun.security.krb5 to DEFAULT_MODULE_OPTIONS 2024-12-19 14:54:21 +08:00
start-all.sh [CELEBORN-1197] Avoid using the sleep command with the s suffix in bash scripts 2023-12-25 16:57:20 +08:00
start-master.sh [CELEBORN-1777] Add java.security.jgss/sun.security.krb5 to DEFAULT_MODULE_OPTIONS 2024-12-19 14:54:21 +08:00
start-worker.sh [CELEBORN-1777] Add java.security.jgss/sun.security.krb5 to DEFAULT_MODULE_OPTIONS 2024-12-19 14:54:21 +08:00
status-master.sh [CELEBORN-976] Introduce script to check master and worker status 2023-09-16 09:27:52 +08:00
status-worker.sh [CELEBORN-976] Introduce script to check master and worker status 2023-09-16 09:27:52 +08:00
stop-all.sh [CELEBORN-564] Correct stop-all.sh comments (#1470) 2023-04-28 09:38:59 +08:00
stop-master.sh [INFRA]Update scripts and templates for new name. (#724) 2022-10-09 14:56:06 +08:00
stop-worker.sh [INFRA]Update scripts and templates for new name. (#724) 2022-10-09 14:56:06 +08:00