Commit Graph

9 Commits

Author SHA1 Message Date
Kent Yao
28449630f3 [CELEBORN-937][INFRA] Improve branch suggestion for backporting
### What changes were proposed in this pull request?

This PR automatically iterates to the next branch to be merged instead of using the latest all the time

### Why are the changes needed?

anti-misoperation

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

manully

Closes #1870 from yaooqinn/CELEBORN-937.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
2023-09-01 00:20:42 +08:00
Kent Yao
ba4f1bb2fe
[CELEBORN-931][INFRA] Fix merged pull requests resolution
### What changes were proposed in this pull request?

This PR fixes the resolution for merged pull requests. It appears that the user "asfgit" is no longer closing pull requests, but rather the committers are.

### Why are the changes needed?

Bugfix, make the merge script re-runnable again if you accidentally abort cherry-pick or change you mind later for backporting

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

tested locally

Closes #1862 from yaooqinn/CELEBORN-931.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
2023-08-30 09:51:34 +08:00
Kent Yao
7e373feea7
[CELEBORN-930][INFRA][FOLLOWUP] Fix environment variable naming
### What changes were proposed in this pull request?

Replace JIRA_USERNAME and JIRA_PASSWORD with ASF_*

### Why are the changes needed?

hotfix

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

manually

Closes #1861 from yaooqinn/CELEBORN-930_F.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
2023-08-29 23:33:04 +08:00
Kent Yao
df8b56a7c7 [CELEBORN-930][INFRA] Eagerly check if the token is valid to align with the behavior of username/password auth
### What changes were proposed in this pull request?

Previously, we allowed for token authentication when resolving Jira issues in pull request merging. However, the token auth is kinda lazy during the initial handshake, maintainers might get confused someday.

This pull request promptly calls the current_user() function to initiate authentication and provides clear instructions for token expiration.

see also 8523ee5d90

### Why are the changes needed?

make it easy for maintainers to update their expired Jira tokens.

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

a maintainer can test this with invalid tokens

Closes #1857 from yaooqinn/CELEBORN-930.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
2023-08-29 21:33:11 +08:00
Kent Yao
2b657c5243 [CELEBORN-918][INFRA] Auto Assign First-time contributor with Contributors role
### What changes were proposed in this pull request?

As an incubating project, first-time contributors‘ welcome is routine. This PR adds automation for granting Contributors role to them to make them a assignable for issues

### Why are the changes needed?

GitHub - JIRA integration

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

tested at apache/spark project, and

```python
>>> asf_jira.project_roles("CELEBORN")
{'Developers': {'id': '10050', 'url': 'https://issues.apache.org/jira/rest/api/2/project/12324920/role/10050'}, 'Contributors': {'id': '10010', 'url': 'https://issues.apache.org/jira/rest/api/2/project/12324920/role/10010'}, 'PMC': {'id': '10011', 'url': 'https://issues.apache.org/jira/rest/api/2/project/12324920/role/10011'}, 'Committers': {'id': '10001', 'url': 'https://issues.apache.org/jira/rest/api/2/project/12324920/role/10001'}, 'Administrators': {'id': '10002', 'url': 'https://issues.apache.org/jira/rest/api/2/project/12324920/role/10002'}, 'ASF Members': {'id': '10150', 'url': 'https://issues.apache.org/jira/rest/api/2/project/12324920/role/10150'}, 'Users': {'id': '10040', 'url': 'https://issues.apache.org/jira/rest/api/2/project/12324920/role/10040'}, 'Contributors 1': {'id': '10350', 'url': 'https://issues.apache.org/jira/rest/api/2/project/12324920/role/10350'}}

```

Closes #1839 from yaooqinn/CELEBORN-918.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
2023-08-26 16:50:31 +08:00
Kent Yao
77abb31a5b
[CELEBORN-910][INFRA] Support JIRA_ACCESS_TOKEN for merging script
### What changes were proposed in this pull request?

This PR supports JIRA_ACCESS_TOKEN for merge script to enable token auth

c36d54a569

### Why are the changes needed?

Tokens are more secure and easily revoked or expired.

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

Your Jira admins can create a token for verification.

Closes #1837 from yaooqinn/CELEBORN-910.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
2023-08-24 20:02:44 +08:00
Kent Yao
1550f92086 [CELEBORN-907][INFRA] The Jira Python misses our assignee when it searches users again
…

### What changes were proposed in this pull request?

detailed desc can be found 8fb799d47b

### Why are the changes needed?

bypass upstream bug

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

I guess pan3793 has already hit the issue when resolving CELEBORN-903 at jira side

Closes #1832 from yaooqinn/CELEBORN-907.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
2023-08-24 11:54:52 +08:00
Kent Yao
ad890e9381
[CELEBORN-903][INFRA] Fix list index out of range for JIRA resolution in merge_pr
### What changes were proposed in this pull request?

This PR fixes list index out-of-range error for the merge_pr script

The error occurs when the branch we merge into does not have a jira project version.

see also cb16591f9b

### Why are the changes needed?

Bugfix

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

verification tbd by maintainer, you can checkout this PR and use this updated one the merge and test

Closes #1827 from yaooqinn/CELEBORN-903.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
2023-08-23 18:49:55 +08:00
Cheng Pan
007b716b64
[CELEBORN-633][INFRA] Introduce PR merge script
### What changes were proposed in this pull request?

Introduce PR merge script `dev/merge_pr.py`, which is borrowed from Apache Spark

### Why are the changes needed?

This script simplifies the PR merge procedure

- auto backport to release branches
- auto close the JIRA ticket
- auto fill in the JIRA fixed version
- reserve the PR description in git log
- reserve the author and committer in git log

### Does this PR introduce _any_ user-facing change?

No, it's for committers.

### How was this patch tested?

a1de16a80f was merged by this tool

Closes #1539 from pan3793/CELEBORN-633.

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
2023-06-02 19:52:04 +08:00