From d44b23c852ed265c6a156c4e46abeb9ffa37e9cb Mon Sep 17 00:00:00 2001 From: Weijie Guo Date: Thu, 7 Nov 2024 10:58:58 +0800 Subject: [PATCH] [MINOR] Remove unused TODO comments in CelebornTierProducerAgent#processBuffer ### What changes were proposed in this pull request? Remove unused TODO comments in CelebornTierProducerAgent#processBuffer ### Why are the changes needed? In order for buffers to be packed together, we are going to modify the Flink side implementation to delegate buffer compression to tiers. But after discussion, we have been able to handle the case of receiving the compressed buffer on the Celeborn side, so this TODO is no longer needed. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need. Closes #2883 from reswqa/remove_unused_todo. Authored-by: Weijie Guo Signed-off-by: Shuang --- .../plugin/flink/tiered/CelebornTierProducerAgent.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/client-flink/flink-1.20/src/main/java/org/apache/celeborn/plugin/flink/tiered/CelebornTierProducerAgent.java b/client-flink/flink-1.20/src/main/java/org/apache/celeborn/plugin/flink/tiered/CelebornTierProducerAgent.java index 983f24cb0..fc2c14982 100644 --- a/client-flink/flink-1.20/src/main/java/org/apache/celeborn/plugin/flink/tiered/CelebornTierProducerAgent.java +++ b/client-flink/flink-1.20/src/main/java/org/apache/celeborn/plugin/flink/tiered/CelebornTierProducerAgent.java @@ -453,9 +453,9 @@ public class CelebornTierProducerAgent implements TierProducerAgent { Buffer buffer = originBuffer; if (originBuffer.isCompressed()) { - // In flink 1.20.0, it will receive a compressed buffer. However, since we need to write - // data to this buffer and the compressed buffer is read-only, - // we must create a new Buffer object to the wrap origin buffer. + // Flink hybrid shuffle will send a compressed buffer to tier. However, since we need to + // write data to this buffer and the compressed buffer is read-only, we must create a + // new Buffer object to the wrap origin buffer. NetworkBuffer networkBuffer = new NetworkBuffer( originBuffer.getMemorySegment(), @@ -466,9 +466,6 @@ public class CelebornTierProducerAgent implements TierProducerAgent { buffer = networkBuffer; } - // TODO: To enhance performance, the flink should pass an no-compressed buffer to producer - // agent and we compress the buffer here - // set the buffer meta BufferUtils.setCompressedDataWithoutHeader(buffer, originBuffer);