apache/celeborn
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CELEBORN-1581] Fix incorrect metrics of DeviceCelebornFreeBytes and DeviceCelebornTotalBytes

Browse Source 
### What changes were proposed in this pull request?
Fix incorrect metrics.

### Why are the changes needed?
The variable `statusSystem.workers` is a set that caused metrics output to be incorrect.

### Does this PR introduce _any_ user-facing change?
NO.

### How was this patch tested?
GA.

<img width="729" alt="截屏2024-08-27 16 48 35" src="https://github.com/user-attachments/assets/c221b680-917a-4207-91fc-c142fac64b65">

Closes #2708 from FMX/b1581.

Authored-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This commit is contained in:
mingji 2024-08-27 20:38:36 +08:00 committed by Shuang
parent 7188b34257
commit cdb5d21d12
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
View File

@ -256,11 +256,11 @@ private[celeborn] class Master(
} }
masterSource.addGauge(MasterSource.DEVICE_CELEBORN_TOTAL_CAPACITY) { () => masterSource.addGauge(MasterSource.DEVICE_CELEBORN_TOTAL_CAPACITY) { () =>
statusSystem.workers.asScala.map(_.totalSpace()).sum statusSystem.workers.asScala.toList.map(_.totalSpace()).sum
} }
masterSource.addGauge(MasterSource.DEVICE_CELEBORN_FREE_CAPACITY) { () => masterSource.addGauge(MasterSource.DEVICE_CELEBORN_FREE_CAPACITY) { () =>
statusSystem.workers.asScala.map(_.totalActualUsableSpace()).sum statusSystem.workers.asScala.toList.map(_.totalActualUsableSpace()).sum
} }
masterSource.addGauge(MasterSource.IS_ACTIVE_MASTER) { () => isMasterActive } masterSource.addGauge(MasterSource.IS_ACTIVE_MASTER) { () => isMasterActive }