From b8253b086409bfa2a903cfd6841bc2a0ccb032df Mon Sep 17 00:00:00 2001
From: "Wang, Fei" <fwang12@ebay.com>
Date: Wed, 23 Jul 2025 15:59:32 +0800
Subject: [PATCH] [CELEBORN-2078] Fix wrong grafana metrics units

### What changes were proposed in this pull request?

Fix the metrics units.

1. bytes -> decbytes, see https://github.com/apache/celeborn/pull/2896
```
metrics_FetchChunkTransferSize_Max
metrics_FetchChunkTransferSize_Mean
```

2. bytes -> none, followup https://github.com/apache/celeborn/pull/3362
```
metrics_LocalFlushSize_Count
metrics_HdfsFlushSize_Count
metrics_OssFlushSize_Count
metrics_S3FlushSize_Count
```

3. ms -> ns, followup https://github.com/apache/celeborn/pull/2990
```
metrics_RpcQueueTime_Max
metrics_RpcQueueTime_Mean
metrics_RpcProcessTime_Max
metrics_RpcProcessTime_Mean
```

4. add unit `decbytes` for `metrics_SortedFileSize_Value`, which was not set before
### Why are the changes needed?

Fix the metrics units.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Code review.

Closes #3381 from turboFei/fix_rpc_unit.

Authored-by: Wang, Fei <fwang12@ebay.com>
Signed-off-by: SteNicholas <programgeek@163.com>
---
 assets/grafana/celeborn-dashboard.json | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/assets/grafana/celeborn-dashboard.json b/assets/grafana/celeborn-dashboard.json
index 0ce5d6576..6c66edc59 100644
--- a/assets/grafana/celeborn-dashboard.json
+++ b/assets/grafana/celeborn-dashboard.json
@@ -5993,7 +5993,7 @@
                   }
                 ]
               },
-              "unit": "bytes"
+              "unit": "decbytes"
             },
             "overrides": []
           },
@@ -6092,7 +6092,7 @@
                   }
                 ]
               },
-              "unit": "bytes"
+              "unit": "decbytes"
             },
             "overrides": []
           },
@@ -6987,7 +6987,7 @@
               }
             ]
           },
-          "unit": "bytes"
+          "unit": "none"
         },
         "overrides": []
       },
@@ -7182,7 +7182,7 @@
               }
             ]
           },
-          "unit": "bytes"
+          "unit": "none"
         },
         "overrides": []
       },
@@ -7377,7 +7377,7 @@
               }
             ]
           },
-          "unit": "bytes"
+          "unit": "none"
         },
         "overrides": []
       },
@@ -7572,7 +7572,7 @@
               }
             ]
           },
-          "unit": "bytes"
+          "unit": "none"
         },
         "overrides": []
       },
@@ -11674,7 +11674,8 @@
                 "value": 80
               }
             ]
-          }
+          },
+          "unit": "decbytes"
         },
         "overrides": []
       },
@@ -15260,7 +15261,7 @@
                   }
                 ]
               },
-              "unit": "ms"
+              "unit": "ns"
             },
             "overrides": []
           },
@@ -15351,7 +15352,7 @@
                   }
                 ]
               },
-              "unit": "ms"
+              "unit": "ns"
             },
             "overrides": []
           },
@@ -15534,7 +15535,7 @@
                   }
                 ]
               },
-              "unit": "ms"
+              "unit": "ns"
             },
             "overrides": []
           },
@@ -15625,7 +15626,7 @@
                   }
                 ]
               },
-              "unit": "ms"
+              "unit": "ns"
             },
             "overrides": []
           },