apache/celeborn
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CELEBORN-2137] Remove unused MAPGROUP PartitionType

Browse Source 
### What changes were proposed in this pull request?

Remove unused `MAPGROUP` `PartitionType`.

### Why are the changes needed?

`PartitionType` `MAPGROUP` is unused at present, which could be removed.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI.

Closes #3459 from SteNicholas/CELEBORN-2137.

Authored-by: SteNicholas <programgeek@163.com>
Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This commit is contained in:
SteNicholas 2025-09-03 09:58:07 +08:00 committed by mingji
parent d038dd2b32
commit 7f08eb8f1d
6 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
common/src/main/java/org/apache/celeborn/common/protocol/PartitionType.java
View File

@ -19,8 +19,7 @@ package org.apache.celeborn.common.protocol;
public enum PartitionType {
REDUCE(0),
MAP(1),
MAPGROUP(2);
MAP(1);
private final int value;

3
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
View File

@ -5043,8 +5043,7 @@ object CelebornConf extends Logging {
.transform(_.toUpperCase(Locale.ROOT))
.checkValues(Set(
PartitionType.REDUCE.name,
PartitionType.MAP.name,
PartitionType.MAPGROUP.name))
PartitionType.MAP.name))
.createWithDefault(PartitionType.REDUCE.name)
val SHUFFLE_PARTITION_SPLIT_THRESHOLD: ConfigEntry[Long] =

2
common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala
View File

@ -113,8 +113,6 @@ object PbSerDeUtils {
// writer always closed as this is committed file info.
fileMeta.setIsWriterClosed(true)
fileMeta
case PartitionType.MAPGROUP =>
throw new NotImplementedError("Map group is not implemented")
}
new DiskFileInfo(
userIdentifier,

1
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala
View File

@ -1085,7 +1085,6 @@ object Utils extends Logging {
value match {
case 0 => PartitionType.REDUCE
case 1 => PartitionType.MAP
case 2 => PartitionType.MAPGROUP
case _ =>
logWarning(s"invalid partitionType $value, fallback to ReducePartition")
PartitionType.REDUCE

4
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
View File

@ -1053,8 +1053,6 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
new ReduceFileMeta(conf.shuffleChunkSize)
case PartitionType.MAP =>
new MapFileMeta()
case PartitionType.MAPGROUP =>
throw new NotImplementedError("Map group is not implemented")
}
val shuffleKey = Utils.makeShuffleKey(appId, shuffleId)
val memoryFileInfo =
@ -1229,8 +1227,6 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
mapFileMeta.setMountPoint(mountPoint)
}
mapFileMeta
case PartitionType.MAPGROUP =>
throw new NotImplementedError("Map group is not implemented")
}
}
}

2
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StoragePolicy.scala
View File

@ -90,8 +90,6 @@ class StoragePolicy(conf: CelebornConf, storageManager: StorageManager, source:
fileInfo.asInstanceOf[DiskFileInfo],
notifier)
}
case PartitionType.MAPGROUP =>
null
}
}