apache/celeborn
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CELEBORN-1413][FOLLOWUP] Check JAVA_HOME variables for release

Browse Source 
### What changes were proposed in this pull request?
For release mode, check the JAVA_HOME variables and set JDK version to 8 by default

```
./build/make-distribution.sh --sbt-enabled --release
```

### Why are the changes needed?

1. Address comments: https://github.com/apache/celeborn/pull/3282#discussion_r2149146734
2. Set JDK 8 for release mode by default is necessary
### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?

Manual test.

Closes #3331 from turboFei/JAVA_HOME.

Authored-by: Wang, Fei <fwang12@ebay.com>
Signed-off-by: Wang, Fei <fwang12@ebay.com>
This commit is contained in:
Wang, Fei 2025-06-16 21:10:54 -07:00
parent cc13c1e643
commit 6f1c10527f
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
build/make-distribution.sh
View File

@ -73,6 +73,14 @@ while (( "$#" )); do
shift
done
if [ "$RELEASE" == "true" ]; then
JAVA8_HOME=${JAVA8_HOME:?"JAVA8_HOME is required"}
JAVA11_HOME=${JAVA11_HOME:?"JAVA11_HOME is required"}
JAVA17_HOME=${JAVA17_HOME:?"JAVA17_HOME is required"}
# Set JAVA_HOME to JDK 8 by default for release
export JAVA_HOME=$JAVA8_HOME
fi
if [ -z "$JAVA_HOME" ]; then
# Fall back on JAVA_HOME from rpm, if found
if [ $(command -v rpm) ]; then

2
build/release/release.sh
View File

@ -29,6 +29,8 @@ RELEASE_RC_NO=${RELEASE_RC_NO:?"RELEASE_RC_NO is required, e.g. 0"}
JAVA8_HOME=${JAVA8_HOME:?"JAVA8_HOME is required"}
JAVA11_HOME=${JAVA11_HOME:?"JAVA11_HOME is required"}
JAVA17_HOME=${JAVA17_HOME:?"JAVA17_HOME is required"}
# Set JAVA_HOME to JDK 8 by default for release
export JAVA_HOME=$JAVA8_HOME
RELEASE_VERSION=$(awk -F'"' '/ThisBuild \/ version/ {print $2}' version.sbt)