From 529fd6e017708490c2319d8acafeb68e4eaeca14 Mon Sep 17 00:00:00 2001 From: sychen Date: Fri, 11 Apr 2025 13:47:41 +0800 Subject: [PATCH] [MINOR] Avoid use `_$eq` in Scala file ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Closes #3208 from cxzl25/minor_eq. Authored-by: sychen Signed-off-by: mingji --- .../scala/org/apache/celeborn/common/meta/WorkerInfo.scala | 4 ++-- .../scala/org/apache/celeborn/common/util/PbSerDeUtils.scala | 2 +- .../org/apache/celeborn/common/meta/WorkerInfoSuite.scala | 2 +- .../org/apache/celeborn/common/util/PbSerDeUtilsTest.scala | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala b/common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala index 2a8f8d6a4..9024c1b7f 100644 --- a/common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala +++ b/common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala @@ -180,8 +180,8 @@ class WorkerInfo( def updateDiskSlots(estimatedPartitionSize: Long): Unit = this.synchronized { diskInfos.asScala.foreach { case (_, disk) => - disk.maxSlots_$eq(disk.totalSpace / estimatedPartitionSize) - disk.availableSlots_$eq(disk.actualUsableSpace / estimatedPartitionSize) + disk.maxSlots = disk.totalSpace / estimatedPartitionSize + disk.availableSlots = disk.actualUsableSpace / estimatedPartitionSize } } diff --git a/common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala b/common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala index 0f7895947..3e0d1afd9 100644 --- a/common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala +++ b/common/src/main/scala/org/apache/celeborn/common/util/PbSerDeUtils.scala @@ -276,7 +276,7 @@ object PbSerDeUtils { disks, userResourceConsumption) if (masterPersistWorkerNetworkLocation) { - workerInfo.networkLocation_$eq(pbWorkerInfo.getNetworkLocation) + workerInfo.networkLocation = pbWorkerInfo.getNetworkLocation } workerInfo } diff --git a/common/src/test/scala/org/apache/celeborn/common/meta/WorkerInfoSuite.scala b/common/src/test/scala/org/apache/celeborn/common/meta/WorkerInfoSuite.scala index 2db11002b..242856500 100644 --- a/common/src/test/scala/org/apache/celeborn/common/meta/WorkerInfoSuite.scala +++ b/common/src/test/scala/org/apache/celeborn/common/meta/WorkerInfoSuite.scala @@ -235,7 +235,7 @@ class WorkerInfoSuite extends CelebornFunSuite { val worker1 = new WorkerInfo("h1", 10001, 10002, 10003, 1000, 10004) val worker2 = new WorkerInfo("h2", 20001, 20002, 20003, 2000, 20004, null, null) - worker2.networkLocation_$eq("/1") + worker2.networkLocation = "/1" val worker3 = new WorkerInfo( "h3", diff --git a/common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala b/common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala index c2c6e4733..3136584b1 100644 --- a/common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala +++ b/common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala @@ -125,7 +125,7 @@ class PbSerDeUtilsTest extends CelebornFunSuite { 1005, diskInfos, userResourceConsumption) - workerInfo1.networkLocation_$eq("/1") + workerInfo1.networkLocation = "/1" val workerInfo2 = new WorkerInfo( "localhost",